ping-protocol icon indicating copy to clipboard operation
ping-protocol copied to clipboard

[WIP] pingmessage: Add function_map variable

Open patrickelectric opened this issue 7 years ago • 3 comments

This new variable will help us to create a better log from all function return the function name and the value on it.

Right now this variable can't return pointer types.

Signed-off-by: Patrick José Pereira [email protected]

patrickelectric avatar Jul 29 '18 14:07 patrickelectric

That's something that I thought. But having two differents implementation of the same thing will increase the debug/development time. Also, the good point to use the same implementation for Qt and pure-cpp is that we catch a bug for both.

patrickelectric avatar Jul 30 '18 21:07 patrickelectric

A subclass with the extra functions is still the same implementation. (I guess QPingMessage is not a good recommendation as it would imply QObject inheritance). We can leave it.

jaxxzer avatar Jul 30 '18 21:07 jaxxzer

We'll need to subclass all pure c++ classes .

patrickelectric avatar Jul 30 '18 22:07 patrickelectric