bluerobotics
sensors-logging: Improve code that generates the subtitle dialogs
Based over https://github.com/bluerobotics/cockpit/pull/739 as a replacement
I think we should indeed pursue this change in the code, as it's clearly better in terms of organization and readability. We just need to make sure it does not introduce bugs.
From my tests last week, I recorded 3 footages. Two of them went fine, while the second one had a problem (line 34) where the time went backwards. The subtitle file is below.
Cockpit (Feb 22, 2024 - 17꞉28꞉00 GMT-3).ass.zip
I think we should indeed pursue this change in the code, as it's clearly better in terms of organization and readability. We just need to make sure it does not introduce bugs.
From my tests last week, I recorded 3 footages. Two of them went fine, while the second one had a problem (line 34) where the time went backwards. The subtitle file is below.
The tests were not done from the PR itself but from the snippets provided on the review. While testing the full code, as provided in this PR, I believe that I was unable to replicate such problem.