bluerobotics
The "tie-joystick-mapping-to-vehicle-type" feature is very much not clear
One looking today at the page below probably has no idea what much of those buttons do. Most people probably just ignore everything and go directly to the buttons mapping.
The feature to tie joystick profiles to vehicle types specially, should be on a separated section, so it is clear to the user what is happening, probably with arrows connecting all the mapped options (MAV_TYPE_SUBMARINE -> "ROV functions mapping", etc).
#1547 may be a preferable solution.
I'm not totally convinced that #1547 is the right approach, but anyway the two implementations are very far in terms of amount of work invested. One is a simple UI change, while the other involves migrations and changes in core structures.
I think it would be valuable to address this in a simpler way, at least till we have the time to decide and invest on the long term solution.
On reflection I think I agree with you that joystick mapping sets can stay as part of the user (for now at least - there are likely to be issues if someone has two ROV profiles, that they want to use different joystick profiles for), but I think it should be possible to rename the mapping, and we should only display the current mapping (and which vehicle types it is used for) except when swapping to a different one: