BlueOS icon indicating copy to clipboard operation
BlueOS copied to clipboard

add Mavftp service, read-only for now

Open Williangalvani opened this issue 2 years ago • 1 comments

This will help #457

thanks @ES-Alexander for the help =]

This adds a mavftp folder under ardupilot_logs image

we should probably fix https://github.com/ArduPilot/ardupilot/issues/23339 or just disable it if a navigator is running.

this is a heavily modified of https://github.com/ArduPilot/MAVProxy/blob/master/MAVProxy/modules/mavproxy_ftp.py I added a fuse layer for it to work with the filelbrowser, and tried to better encapsulate functionality.

That said, I hate it. but it works. I still think we should probably move this to a dedicated rust service later on.

I thought of using mavlink2rest, but I'm worried about the performance of assembling the arraybuffers from the jsons. That would also go against my idea of upstreaming this to ardupilot eventually.

This could be further cleaned, but I'll open it for review to double-check this is path we want to follow.

Williangalvani avatar Mar 25 '22 18:03 Williangalvani

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 23 '23 17:08 CLAassistant

changed it so it gets code from pymavlink directly. currently WIP as we wait for the PR to be merged over there

Williangalvani avatar Sep 30 '24 19:09 Williangalvani