BlueOS
BlueOS copied to clipboard
bug: vehicle-setup: barometer representation issues
Bug description
- Aerial barometers have their type displayed as "Freshwater Pressure", but should be something like "Internal Pressure" / "Aerial Pressure"
- This seems to only be a Sub issue, although in Rover it comes up as "Unknown Pressure", which isn't great either
- Bar30 (
MS5837-30BA) shows up asMS5611(I2C)
Steps to reproduce
- Connect flight controller to BlueOS computer, and view the "Autopilot Sensors" section of the Vehicle Setup page
- Connect a Bar30 and restart the autopilot
Primary pain point(s)
- This is incorrect, and misleadingly may cause people to believe they have one or more connected water pressure sensors that are actually internal / aerial
- Showing the wrong sensor type is confusing, especially in the Pixhawk which already has an internal MS5611 barometer connected via SPI
Additional context
A somewhat relevant forum thread, from a while ago.
Prerequisites
- [X] I have checked to make sure that a similar request has not already been filed or fixed.
- From some digging after a discussion with @Williangalvani, I think this should just be an
if-else, so the "not water sensor" doesn't get overwritten with the water sensor value- EDIT: that may be true, but it looks like we're calling
MS5611a water sensor indiscriminately, so we may need to change that condition to also consider how it's being communicated with (SPI/I2C/etc) / whether it's internal (if we're able to check that)
- EDIT: that may be true, but it looks like we're calling
- This is likely an ArduPilot mis-reporting issue, but until that's resolved it may still be worth hedging our bets that an external
MS5611sensor connected via I2C and with a water density is very likely actually a Bar30 (MS5837-30BA)
#2560 fixes most of this, and ArduSub-4.5 (currently beta) fixes the sensor name issue (correctly displays MS5837 for the Bar30, and MS5611 for the internal/aerial one).