BlueOS icon indicating copy to clipboard operation
BlueOS copied to clipboard

bug: vehicle-setup: lights config not working for PWM outputs below number 8

Open ES-Alexander opened this issue 1 year ago • 0 comments

Bug description

If a PWM output <= 8 is configured as a lights output it doesn't show up correctly.

Screenshot 2024-04-05 at 2 57 27 am Screenshot 2024-04-05 at 2 57 06 am

As a side note, the "Lights" cards seem to not have any horizontal spacing between them, which looks unpleasant.

Steps to reproduce

  1. Configure a lights output to <= 8
  2. Check the "Lights" page, and it doesn't appear

Alternatively,

  1. On the "Lights" page, try to set a servo <= 8 (they don't get shown, so it's not possible)

Primary pain point(s)

I should be able to choose the purpose I assign to my PWM output channels, and especially for channels that aren't already known to have some other critical function assigned (e.g. motors).

Additional context

The standard BlueROV2 has only 6 thrusters, so at minimum outputs 7+8 should definitely be supported while using that frame, and same for non-motor outputs on other vehicle frames (otherwise we're arbitrarily restricting which servo outputs can be used for a given purpose).

Prerequisites

  • [X] I have checked to make sure that a similar request has not already been filed or fixed.

ES-Alexander avatar Apr 04 '24 16:04 ES-Alexander