BlueOS icon indicating copy to clipboard operation
BlueOS copied to clipboard

We should delete older extensions once update is done

Open patrickelectric opened this issue 1 year ago • 3 comments

The system is not being cleaned, when updating a extension to a newer version we should delete the previous one

patrickelectric avatar Jan 20 '24 14:01 patrickelectric

We definitely need a mechanism for deleting old extension images, but from a "you own what you've paid for" perspective I think users should be given a choice whether they want to (since they may not be able to download them again if the developer has removed the version from hosting), instead of it being forcibly automatic, and they should also be able to roll back to old versions at will (like we allow for the core image with VersionChooser).

ES-Alexander avatar Jan 26 '24 05:01 ES-Alexander

I guess the issue is here:

https://github.com/bluerobotics/BlueOS/blob/master/core/services/kraken/kraken.py#L197-L210

we should do remove(..., True) in order to delete. but we have to do it only after we confirm the pull was successful

Williangalvani avatar Feb 01 '24 19:02 Williangalvani

Related to #2365

patrickelectric avatar Feb 19 '24 12:02 patrickelectric