gortsplib icon indicating copy to clipboard operation
gortsplib copied to clipboard

track_h264: avoid appending empty sps to fmtp line

Open tmatth opened this issue 2 years ago • 3 comments

This avoids adding fmtp lines of the form "sprop-parameter-sets=" with no value (which leads to malformed SDPs).

tmatth avatar Jun 08 '22 21:06 tmatth

For context I noticed this behaviour when trying to figure out a regression in our usage of rtsp-simple-server since v0.17.17 where the profile-level-id is being stripped and these spurious sprop-parameter-sets= strings are added.

This doesn't completely fix our issue (as the profile-level-id is still being stripped) but I think makes sense on its own.

tmatth avatar Jun 08 '22 21:06 tmatth

Hello, what's the name of the client that warns about malformed SDPs? i've seen a lot of cameras (mostly HikVision) that outputs an empty sprop-parameter-sets.

aler9 avatar Jun 11 '22 09:06 aler9

Hello, what's the name of the client that warns about malformed SDPs? i've seen a lot of cameras (mostly HikVision) that outputs an empty sprop-parameter-sets.

Wireshark :laughing:

tmatth avatar Jun 13 '22 14:06 tmatth

bump

tmatth avatar Oct 11 '22 20:10 tmatth

This issue is being locked automatically because it has been closed for more than 6 months. Please open a new issue in case you encounter a similar problem.

github-actions[bot] avatar Apr 25 '23 15:04 github-actions[bot]