NetUsage NM serial device was removed in 0.9

[infirit]

https://developer.gnome.org/NetworkManager/1.0/ref-migrating.html#id-1.4.3.12

I personally do not have a DUN phone so it's hard for me to port this part of the plugin to GDBus. But IMO we should fix this before we release the 2.1 final.

[infirit]

Looking at the NM dbus api there is no such thing as PppStats anywhere to be found...

[cschramm]

There is still some stats stuff in the current NM code, but I cannot find a way to access it (also via glib). We could read it ourselves using ioctl, though:

        struct ifreq req;
        struct ppp_stats stats;

        memset (&req, 0, sizeof (req));
        memset (&stats, 0, sizeof (stats));
        req.ifr_data = (caddr_t) &stats;

        strncpy (req.ifr_name, priv->ip_iface, sizeof (req.ifr_name));
        ioctl (priv->monitor_fd, SIOCGPPPSTATS, &req);

[infirit]

Good, I don't have a phone like that so no means of working on this.

[infirit]

These statistics are exposed in dbus org.freedesktop.NetworkManager.Device.Statistics

Now that I have a way of testing dun when I have some time I'll update NetUsage to use this interface.

[infirit]

However org.freedesktop.NetworkManager.Device.Statistics requires a dun connection to be created in NM properly like I did in #910. I am not sure but I suspect it will not be available if we use PPPSupport unless NM has a connection for the dun device.

Also, rfcomm does not show up in /sys/class/net/ (as one would expect as its not a network device) so using the Monitor class will not work for DUN, only for PAN. What I'll probably do is some cleanup and drop support for DUN when using PPPSupport.

Actions items I have right now are:

• For DUN with PPPSupport do not create a monitor just log an error that it is not implemented.
• Drop storing a list of bluetooth addresses that have stats in gsettings, its pointless and likely something that was needed with GConf.
• Implement a Gio.DBusProxy class that will use the nm statistics interface
• If NM is available use the proxy class for PAN
• Fix bugs along the way like never setting a log start time on first device use.

edit: GFileMonitor on sysfs appears completely broken so drop this from the list

[infirit]

@cschramm removed the remaining bits from NetUsage. But I do like to add support for org.freedesktop.NetworkManager.Device.Statistics at some point. But not in 2.1 so removing milestone.