blueman icon indicating copy to clipboard operation
blueman copied to clipboard

Manager: Use toggle button to replace status icon

Open infirit opened this issue 11 months ago • 3 comments

Here is what I have so far. Still need to:

  • cleanup
  • drop menu entry
  • perhaps change color of the button

The idea here is that the toggle button is "active" when bluetooth is enabled and showing label and icon what would happen if the button is pressed, disable bluetooth.

image

image

infirit avatar Feb 28 '24 22:02 infirit

This should be it for now. Let me know if you want me to change or add things.

infirit avatar Mar 04 '24 18:03 infirit

I think that makes a lot of sense. :ok_hand:

Not sure about the "active" visualization, though. It feels wrong that the button is highlighted (in sense of a primary action) when it allows to turn Bluetooth off while it's not when it allows to turn it on. From that perspective, I'd expect the contrary. Not sure, but it might make sense to just not highlight any of the states (I see that the state might be less obvious then).

cschramm avatar Mar 10 '24 16:03 cschramm

Perhaps a Gtk.Switch is more appropriate as it can have proper on/off labels. Let me see how that looks.

infirit avatar Mar 18 '24 09:03 infirit

Here is how I can look with a switch. I didn't add a label as I don't see what that would add, I can so let me know if you want it. image image

infirit avatar Mar 18 '24 21:03 infirit

I think that's perfect!

cschramm avatar Mar 19 '24 09:03 cschramm

Cool, I'll commit that and push it tonight.

infirit avatar Mar 19 '24 15:03 infirit

Updated with the switch

infirit avatar Mar 19 '24 15:03 infirit