blueman icon indicating copy to clipboard operation
blueman copied to clipboard

Published 20 hours ago • verified publisher icon blueman-project

Meson uninstalled attempt 2

Open infirit opened this issue 3 years ago • 8 comments

This appears to work for me. Yes it copies all the files to the build dir but for now I don't care. I just want it to work so we can drop autotools. If someone want to spend the time to figure out other options they can and send a PR.

It needs some testing and I will have to update the release job in main.

edit. I'll also fix the other jobs over the weekend.

infirit avatar Jul 22 '22 15:07 infirit

Fixed the jobs.

Just one concern/question, the release job version check command works when I run it in a terminal. Not sure it'll work in CI :thinking:

infirit avatar Jul 22 '22 20:07 infirit

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 23 '22 07:07 sonarqubecloud[bot]

Fixed per comments.

infirit avatar Jul 23 '22 07:07 infirit

To be honest, I'm not super happy with the workflow yet, as a debug cycle now means editing the sources, syncing them into the build directory with ninja and setting breakpoints etc. in the build directory, thus in a different context, but I guess I'll get used to it.

One idea: Shouldn't it be rather easy to reliably detect that an app is running from a build directory instead of using BLUEMAN_SOURCE? It should e.g. find meson-info next to it.

cschramm avatar Jul 25 '22 10:07 cschramm

We could drop Constants for another way to configure paths. I could move these things to a JSON file and allow the apps to load a custom one on the command line.

infirit avatar Jul 25 '22 14:07 infirit

Totally forgot to add that README.md and Dependencies.md need updates.

cschramm avatar Jul 25 '22 15:07 cschramm

We could drop Constants for another way to configure paths. I could move these things to a JSON file and allow the apps to load a custom one on the command line.

I commented here about some possible solutions: https://github.com/blueman-project/blueman/pull/1207#issuecomment-1189469738

Loading a json file from the command line doesn't seem like the best solution to me as meson devenv is supposed to make things work without command line options, usually via environment variables.

eli-schwartz avatar Jul 25 '22 19:07 eli-schwartz

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 01 '24 08:03 sonarqubecloud[bot]