gcache gcache with context

Jun 18 '19 18:06 dragonsinth

update readme

Dec 14 '19 08:12 greyireland

Upvoting

Apr 26 '22 09:04 sonu27

would be great to have this change merged

Feb 06 '23 14:02 alexanderbolgov-ef

No tests for Context timeout/Context related functionality

Feb 21 '23 13:02 romansonrai

I didn't see a compelling need; the functional changes are almost nothing; it's mostly just plumbing ctx around everywhere.

Feb 21 '23 16:02 dragonsinth

For the most part I certainly agree with you, but the changes in singleflight.go (Do function) are comparatively substantial. And that would be the only place I would include additional tests.

Feb 21 '23 17:02 romansonrai

Fair enough. But worth noting that this PR has grown stale and needs rebase+conflict res. I'm not inclined to keep working on this PR without some indication that there's a path to getting this merged.

Feb 21 '23 18:02 dragonsinth

Yes, I agree….looks like the owner ditched the project…in any case, I love the code and the use case is a very common one.

On Feb 21, 2023, at 2:30 PM, Scott Blum @.***> wrote:

Fair enough. But worth noting that this PR has grown stale and needs rebase+conflict res. I'm not inclined to keep working on this PR without some indication that there's a path to getting this merged.

— Reply to this email directly, view it on GitHub https://github.com/bluele/gcache/pull/61#issuecomment-1438924637, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4FXSSOJKACVOP7S7VAHVO3WYUCSXANCNFSM4HZC2FCA. You are receiving this because you commented.

Feb 24 '23 15:02 romansonrai