Billy Keyes

Results 160 comments of Billy Keyes

Policy Bot has a limited ability to post failures on pull requests by using `disapproval` policies. Unlike `approval` policies, disapproval only supports a single rule, so you can't opt-out specific...

If we were to implement something like this, I think one way to do it is to expand how disapproval works so that it can contain multiple rules and conditions,...

Thanks for reporting this. Was the PR with this problem open for a relatively long time? I think it's unusual to have so many events for a single SHA (usually...

Thanks starting an implementation of this feature! I don't have any objections to dismissing stale reviews, so I think it's worthwhile to continue testing and iterating here. This hasn't been...

Not sure if you've tried this yet, but for weird API issues, I usually resort to using the Ruby script from [Authenticating as a GitHub App](https://docs.github.com/en/developers/apps/building-github-apps/authenticating-with-github-apps#authenticating-as-a-github-app) to generate a JWT,...

Yeah, I agree that implementing dismissal as part of the filtering logic would feel wrong, but I don't think combing the `pull_request` and `pull_request_review` handlers is the best alternative. There...

Based on @daiglebg's testing in #276, I've changed this to use a fixed 2 second delay for updates. With the maximum value that low, exponential backoff hit the limit so...

Sorry for letting this sit for so long. Unfortunately, none of the maintainers have the expertise with Helm needed to review this and then keep it updated it once merged....

This is an interesting idea and would definitely help improve the predictability of merges and reduce the load on CI systems caused by PR updates. But as you pointed out,...

Thanks for outlining this approach, @merrywhether. I like the idea of a `strategy` option and the `newest` and `oldest` strategies sound straightforward and are something I'm willing to support. Having...