kubedirector icon indicating copy to clipboard operation
kubedirector copied to clipboard

be more robust to admission webhook issues

Open joel-bluedata opened this issue 6 years ago • 1 comments

If the mutating admission controller is not enabled on K8s (cf. issue #2), our webhook will just silently never get called for anything. This breaks some of our admission control which leads to unexpected consequences. One obvious bad thing is that code that assumes a non-nil number of role members will crash, but there are other bad things.

I don't think we should even try to make the reconciliation code robust against the possibility of broken admission control. Instead, at startup time KD needs to probe whether the validator is working (send a request to it and make sure the request is received) and shut down if the validator is broken.

joel-bluedata avatar Oct 02 '18 21:10 joel-bluedata

Possibly related to issue #111.

joel-bluedata avatar Nov 26 '18 06:11 joel-bluedata