ecmwfr icon indicating copy to clipboard operation
ecmwfr copied to clipboard

`wf_requests_batch()` accepts requests that overwrite each other

Open eliocamp opened this issue 1 year ago • 3 comments

A friend of mine (definitely not me :rofl: ) sent a bunch of requests but forgot to change the filename in the target slot, so wf_requests_batch() downloaded every request in the same filename, which was a total waste of everyone's time.

Should the function check for this issue and error out early? My gut tells me it should, since I don't see any situation in which the user would want wf_requests_batch() to overwrite requests.

eliocamp avatar Aug 31 '22 16:08 eliocamp

Yep, probably best to do some checks. Grab all filenames and if (any(duplicated(filenames))) {} should do the trick.

khufkens avatar Sep 01 '22 19:09 khufkens

There.

I've just noticed that this is issue 100! :tada:

eliocamp avatar Sep 01 '22 20:09 eliocamp

Wonderful, will push this to CRAN next week or so. Stuff is piled high and deep for the moment.

khufkens avatar Sep 02 '22 07:09 khufkens