audioplayers icon indicating copy to clipboard operation
audioplayers copied to clipboard

option to disable logging

Open shawn736 opened this issue 5 years ago • 4 comments

Please don't use NSLog in iOS to print information, or a switch is needed. For example : NSLog(@"iOS => call %@, playerId %@", call.method, playerId);

shawn736 avatar Apr 25 '19 11:04 shawn736

I think we should remove all logs from both android and ios, there used to be an issue about that. We'd be glad if you could contribute with a PR, @shawn736 .

luanpotter avatar Apr 25 '19 12:04 luanpotter

I think the disableLogs dart method should notify both backends via a channel to stop all logs. Then on ios introduce an if statement in the log function (just like that dart side does). For android, apart from that, we need to configure the MediaPlayer class to stop with the random logging.

It should be a relatively easy improvement if someone is interested in helping out :)

luanpotter avatar Jun 04 '19 23:06 luanpotter

@luanpotter did this got fixed when the refactor to swift was made?

erickzanardo avatar Mar 25 '21 21:03 erickzanardo

Not yet, I made a refactor to allow it but didn't wire yet.

luanpotter avatar Apr 10 '21 17:04 luanpotter