audioplayers icon indicating copy to clipboard operation
audioplayers copied to clipboard

feat: select decoder automatically on windows

Open Yesterday17 opened this issue 2 years ago • 0 comments

Description

This pull request makes audio playback not depend on file extension on Windows by adding the MF_RESOLUTION_CONTENT_DOES_NOT_HAVE_TO_MATCH_EXTENSION_OR_MIME_TYPE flag.

Before this pr, the file extension of an audio file must be correct. However, it's common that file extension mismatches, or for cached audio files which may not have an extension.

I'm not sure whether this should be a feature or bug fix. On macOS, the player expects whatever extension for playback, but the extension must exist.

Checklist

  • [x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • [x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • [x] I have updated/added tests for ALL new/updated/fixed functionality.
  • [x] I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • [x] I have updated/added relevant examples in example.

Breaking Change

  • [ ] Yes, this is a breaking change.
  • [x] No, this is not a breaking change.

Related Issues

Yesterday17 avatar Jul 24 '22 15:07 Yesterday17

@Yesterday17 you have turned off commits from maintainers I think, can you update the branch to the latest main?

spydon avatar Aug 16 '22 07:08 spydon

@Yesterday17 you have turned off commits from maintainers I think, can you update the branch to the latest main?

Done

Yesterday17 avatar Aug 16 '22 07:08 Yesterday17