audioplayers icon indicating copy to clipboard operation
audioplayers copied to clipboard

Getting Started tutorial references renamed and no longer existing streams in v1

Open dvorapa opened this issue 3 years ago • 1 comments

Getting Started tutorial references some streams, that are renamed or no longer exist in v1. I've caught at least these three:

  error • The getter 'onAudioPositionChanged' isn't defined for the type
         'AudioPlayer' • lib/main.dart:1004:17 • undefined_getter
  error • The getter 'onPlayerCompletion' isn't defined for the type
         'AudioPlayer' • lib/main.dart:1023:17 • undefined_getter
  error • The getter 'onPlayerError' isn't defined for the type 'AudioPlayer' •
         lib/main.dart:1033:17 • undefined_getter

The first two obviously have just been renamed. They should be renamed in the tutorial as well. But the third one seems no longer existing in the audioplayers package - at least I haven't found it yet.

Code to Reproduce

  1. Open the Getting Started tutorial ( https://github.com/bluefireteam/audioplayers/blob/main/getting_started.md )
  2. Add audioplayers as a dependency into some Flutter app
  3. Copy and paste the code examples for the three streams mentioned above directly from Getting Started tutorial to your Flutter app
  4. Run flutter pub get && flutter analyze

Platforms

  • flutter version: 3.0.4
  • audioplayers version: 1.0.1

dvorapa avatar Jul 02 '22 16:07 dvorapa

  • The last one covered by #1179
  • The second one fixed in #1189

dvorapa avatar Jul 02 '22 16:07 dvorapa

First one via: #1275

Gustl22 avatar Sep 27 '22 18:09 Gustl22