blueedgetechno
[WIP] Add Dual Monitor Support and Add WiFi Icon Changes
Description
WIP - Description will be added once complete and ready for review.
Closes #292
Type of change
- [x] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] This change requires a documentation update
✔️ Deploy Preview for Ready! 😎 Browse the preview: https://pr-preview.win11react.com/488 ! 🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/2410498963
✔️ Deploy Preview for Ready! 😎 Browse the preview: https://pr-preview.win11react.com/488 ! 🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/2410530952
One wouldn’t deploy, one is outdated, and this one is the current. Not sure about the other two.
i don't understand the need for line 20 , 60-90 in taskbar/index.js
I did not add most of that... dunno why it shows it?
i don't understand the need for line 20 , 60-90 in taskbar/index.js
also line 90-120 should be in components/wifi.js instead of taskbar/index.js so that it can be used in other places like lockscreen, action centre, etc
Will do.
✔️ Deploy Preview for Ready! 😎 Browse the preview: https://pr-preview.win11react.com/488 ! 🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/2416790225
u missed this part ig
✔️ Deploy Preview for Ready! 😎 Browse the preview: https://pr-preview.win11react.com/488 ! 🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/2416804665
I did not add most of that... dunno why it shows it?
i think the reason could be that earlier we used to have that battery logic in taskbar/index.js later i refactored it to battery.js so it could be reused in other places like lockscreen too. and you started work on wifi before i had refactored it.
✔️ Deploy Preview for Ready! 😎 Browse the preview: https://pr-preview.win11react.com/488 ! 🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/2416814632
I did not add most of that... dunno why it shows it?
i think the reason could be that earlier we used to have that battery logic in taskbar/index.js later i refactored it to battery.js so it could be reused in other places like lockscreen too. and you started work on wifi before i had refactored it.
Got it, ~~btw you should check your email lol~~
Got it, ~btw you should check your email lol~
weird i didn't receive any email wen did u send it can you resend please
Edit: i had received it but somehow missed it :|
✔️ Deploy Preview for Ready! 😎 Browse the preview: https://pr-preview.win11react.com/488 ! 🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/2416902866
✔️ Deploy Preview for Ready! 😎 Browse the preview: https://pr-preview.win11react.com/488 ! 🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/2416995362
also the new battery level just gets updated in one of the 3places it is used (lockscreen, actionCenter, taskbar)
i think we can fix this by storing the battery percent in src/reducers/settings.js maybe
we can add a battery option here
also the new battery level just gets updated in one of the 3places it is used (lockscreen, actionCenter, taskbar)
i think we can fix this by storing the battery percent in src/reducers/settings.js maybe
we can add a battery option here
Will do.
One wouldn’t deploy, one is outdated, and this one is the current. Not sure about the other two.
On Tue, May 31, 2022 at 12:31, notAperson535 @.***> wrote:
Why has there been like 5 of these PRs?
— Reply to this email directly, view it on GitHub https://github.com/blueedgetechno/win11React/pull/488#issuecomment-1142360266, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANI5RBIRXBY6WSGXKCZODFDVMY5GFANCNFSM5XLFU3OA . You are receiving this because you were assigned.Message ID: @.***>
-- Best Wishes, Lukas Batema (Java, JavaScript, and Front End Web Developer; Moderator on PedestriaMC Network)