fortigate_exporter Adding ha metrics for failover detection

Adding ha metrics for failover detection

Open galcorlo opened this issue 3 years ago • 2 comments

Resolve: https://github.com/bluecmd/fortigate_exporter/issues/177

Already added is_root_master just in case because checking the dashboard widget it seems we only need is_manage_master

Aug 08 '22 10:08 galcorlo

I agree with all your modifications :)

Aug 09 '22 06:08 galcorlo

I agree with all your modifications :)

Nice! Ping me when you have made the modifications and I'll approve and merge

Aug 09 '22 06:08 bluecmd

Hello Christian, not sure if I accepted all your proposed modifications. I'm a bit overwhelmed with the github interface/workflow

Thanks!

Aug 16 '22 12:08 galcorlo

Hello Christian, not sure if I accepted all your proposed modifications. I'm a bit overwhelmed with the github interface/workflow

Thanks!

I think what you did was closing my suggestions without merging them - and that's totally fine, but then you have to manually apply them.

Aug 16 '22 15:08 bluecmd

Hi, any ETA for this to be merged? thanks!

Aug 23 '22 08:08 tiagoasousa

:tada: This PR is included in version 1.17.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Aug 23 '22 15:08 bluecmd