kafka-connect-protobuf-converter icon indicating copy to clipboard operation
kafka-connect-protobuf-converter copied to clipboard

Fixed bug that was leading to failure in avro format

Open ashishmalgawa opened this issue 5 years ago • 3 comments

If you have a protobuf file like this MessageA{ MessageB hello = 1; } MessageB{ MessageC hello = 1; } MessageC{ String abc =1; }

Then this would result in an error in avro converter, since in the current code the name of the schema for MessageB and MessageC will be Hello. I've changed the name of the schema, now it will contain the name of the Message Type instead of the fieldname.

ashishmalgawa avatar May 08 '20 07:05 ashishmalgawa

Can this be reviewed/merged? It will make it easy to work with large schemas where potential of name collision is high.

abhishekagarwal87 avatar May 08 '20 11:05 abhishekagarwal87

I faced this issue too, and this PR fixes it. Is this project still supported? Can we get this merged?

prokopiff avatar Mar 13 '23 10:03 prokopiff

hi, thanks for your interest. We're archiving the repo, you can find a good replacement here https://www.confluent.io/hub/confluentinc/kafka-connect-protobuf-converter

mdering avatar Jun 30 '23 20:06 mdering