kafka-connect-protobuf-converter icon indicating copy to clipboard operation
kafka-connect-protobuf-converter copied to clipboard

Support for camelCase

Open darwinbeard opened this issue 5 years ago • 3 comments

Currently, kafka-connect-protobuf-converter converts proto messages to the object with keys in snake_case.

It happens on line 71: https://github.com/blueapron/kafka-connect-protobuf-converter/blob/master/src/main/java/com/blueapron/connect/protobuf/ProtobufData.java#L71 String name = descriptor.getName();

Having an option that toggles between snake_case and camelCase would be great.

Changing line 71 mentioned above to: String name = descriptor.getJsonName(); does it functionality; however, breaks a lot of tests.

darwinbeard avatar Nov 13 '19 21:11 darwinbeard

@darwinbeard If this is still an issue, please open a pull request and I can approve, otherwise, please close!

normzeng avatar Feb 11 '20 22:02 normzeng

I'm working on this feature. I'll submit a PR when ready.

ebbnflow avatar Jan 10 '23 15:01 ebbnflow

@ebbnflow any update?

malthe avatar Feb 21 '23 20:02 malthe