revm icon indicating copy to clipboard operation
revm copied to clipboard

Ability to ignore block gas limit validation

Open Wodann opened this issue 3 years ago • 2 comments

At hardhat we've so far been using ethereumjs, but we're rewriting parts to Rust and are using revm to do so.

One of the features that ethereumjs supports but is absent in revm is the ability to skip the validation for Return::CallerGasLimitMoreThenBlock: https://github.com/bluealloy/revm/blob/main/crates/revm/src/evm_impl.rs#L69.

In ethereumjs this is handled by providing config options for running a transaction: https://github.com/ethereumjs/ethereumjs-monorepo/blob/master/packages/vm/src/types.ts#L306

Is this something that you'd be willing to accept a PR for? If so, do you have a preference for how it should be implemented?

Wodann avatar Oct 19 '22 23:10 Wodann

Can be done similar to this: https://github.com/bluealloy/revm/issues/235#issuecomment-1285283823

Just curious, wouldn't increasing block.gas_limit or making tx.gas_limit same as block.gas_limit solve this?

rakita avatar Oct 20 '22 10:10 rakita

This is the motivation for having an override: https://github.com/ethereumjs/ethereumjs-monorepo/issues/1014

Wodann avatar Oct 20 '22 15:10 Wodann