tsfresh icon indicating copy to clipboard operation
tsfresh copied to clipboard

tsfresh/docs/text/quick_start.rst does not reflect data

Open danielfeinblatt opened this issue 4 years ago • 2 comments

I recently started exploring tsfresh and began with the quickstart page. However, the instructions do not appear to reflect the data. I am happy to implement a change, but as I am new to the community, want to see what was intended. Specifically the y data in the mini-tutorial comes out as a series of type: bool, rather than integers as displayed in the page. Also, when following the plotting step, my plots have very little resemblance to those found on the page, which may be cause for confusion to many. It appears many of the plot formatting code was left out, which I assume is for clarity sake and to show the simplicity of tsfresh. However, I think it would be quite helpful to include for beginners to this package. I am using version 0.16.0 for reference, running in jupyter notebooks.

danielfeinblatt avatar Jun 01 '20 18:06 danielfeinblatt

Hello @danielfeinblatt! Thanks for the issue. Very good, we are very happy if you could fix this with a PR. If possible, you can keep the plotting code at a minimum - even if the plots might change (but feel free to add as much plotting code as needed to convoy the message). Thanks for looking into that.

nils-braun avatar Jun 01 '20 21:06 nils-braun

@danielfeinblatt Did you had some time to look into this? Should we have a look at our side or will you find some time? No pressure, we are more than happy if more people want to contribute! :-)

nils-braun avatar Jun 25 '20 18:06 nils-braun