tsfresh icon indicating copy to clipboard operation
tsfresh copied to clipboard

Remove or unittest index cast at the end of the feature extraction

Open nils-braun opened this issue 4 years ago • 1 comments

Are we testing the types of indices that need this recasting in some unit tests? If not, do we actually need this line of casting?

Originally posted by @MaxBenChrist in https://github.com/blue-yonder/tsfresh/pull/705

nils-braun avatar May 28 '20 09:05 nils-braun

IMHO this is the exact same problem as with sort_index; current code looks good, it seems natural to return a DataFrame with an index identical to df[column_id]. I do not see why this should be changed or tested, there is no test to ensure that index is sorted.

dbarbier avatar May 28 '20 09:05 dbarbier