blueoil icon indicating copy to clipboard operation
blueoil copied to clipboard

Refactored training function. (#481)

Open ed728 opened this issue 5 years ago • 3 comments

What this patch does to fix the issue.

Splits the start_training function into functions in a class. More readability changes will be added later. This commit just moves functionality around. The functions was very large, so a smaller commit than this was not possible. This commit only moves stuff around for ease of reviewing.

Link to any relevant issues or pull requests.

Based on #481 .

More PRs will be added after this.

Testing.

Manual and CI.

ed728 avatar Dec 19 '19 02:12 ed728

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review Approval, LGTM

  • Approve all ownership reviews Ownership Approval or OA

  • Approve all readability reviews Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

bo-code-review-bot[bot] avatar Feb 28 '20 00:02 bo-code-review-bot[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 12 '20 06:06 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 12 '20 06:06 CLAassistant