blueoil
blueoil copied to clipboard
Remove config yaml
The config.yaml
file contains the same information as the config.py
file. So, it is possible to remove the code related to config.yaml
. This is stated in https://github.com/blue-oil/blueoil/issues/1224. A second point is that loading the config.yaml
can cause error https://github.com/blue-oil/blueoil/pull/1110. So this PR would also resolve that problem.
After modifying the code, I tried training, exporting, and converting. All seemed to run fine. No config.yaml
appears.
p.s. in the save_yaml
function, I just remove the config.yaml
part, not the meta.yaml
part.
This PR needs Approvals as follows.
- Ownership Approval for
/
from iizukak, tkng, ruimashita - Readability Approval for
Python
from tkng, tsawada, tfujiwar, a-hanamoto
Please choose reviewers and requet reviews!
Click to see how to approve each reviews
You can approve this PR by triggered comments as follows.
-
Approve all reviews requested to you (readability and ownership) and LGTM review
Approval, LGTM
-
Approve all ownership reviews
Ownership Approval
orOA
-
Approve all readability reviews
Readability Approval
orRA
-
Approve specified review targets
- Example of Ownership Reviewer of
/
:Ownership Approval for /
orOA for /
- Example of Readability Reviewer of
Python
:Readability Approval for Python
orRA for Python
- Example of Ownership Reviewer of
-
Approve LGTM review
LGTM
See all trigger comments
Please replace [Target] to review target
- Ownership Approval
- Ownership Approval for [Target]
- OA for [Target]
- Ownership Approval
- OA
- Approval
- Readability Approval
- Readability Approval for [Target]
- RA for [Target]
- [Target] Readability Approval
- [Target] RA
- Readability Approval
- RA
- Approval
- LGTM
- LGTM
- lgtm
@iizukak how do you think about these changes?
One possible contentious point is that the save_yaml
function remains, for saving the meta.yaml
. I think that meta file may be important for running certain kinds of demo https://github.com/blue-oil/blueoil/blob/master/docs/usage/export.md so it's better to keep it.