blueoil icon indicating copy to clipboard operation
blueoil copied to clipboard

Published 20 hours ago • verified publisher icon blue-oil

Create prototype of unit-test

Open lm-kajihara opened this issue 4 years ago • 5 comments

Related to #743 Using googletest ([https://github.com/google/googletest]) and DownloadProject ([https://github.com/Crascit/DownloadProject]) All .cpp files in "tests/converter/unit-test/src" are unit test file of converter C++ runtime. And all header files in "tests/converter/unit-test/include" are dummy of files in "blueoil/converter/templates/include". This PR include only template function test. (I forgot to remove pragma once in "tests/converter/unit-test/include")

lm-kajihara avatar Sep 15 '20 09:09 lm-kajihara

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 15 '20 09:09 CLAassistant

change pop_count.h and CMakeLists.txt to use converter implementation and remove "pramga once" in unit-test

lm-kajihara avatar Sep 25 '20 08:09 lm-kajihara

@lm-kajihara is this PR still WIP ?

primenumber avatar Oct 12 '20 05:10 primenumber

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for C++ from tkng, tsawada, primenumber

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review Approval, LGTM

  • Approve all ownership reviews Ownership Approval or OA

  • Approve all readability reviews Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

bo-code-review-bot[bot] avatar Oct 15 '20 09:10 bo-code-review-bot[bot]

Remove "[WIP]" from this PR name. I can't write more test because I don't know that expected bevavior of functions.

lm-kajihara avatar Oct 15 '20 09:10 lm-kajihara