cli icon indicating copy to clipboard operation
cli copied to clipboard

instead of suffixing fedora version in tags, suffix the alt-tag or `latest`

Open noahdotpy opened this issue 1 year ago • 9 comments

Currently my tags look something like this for the alt-tags set as only stable:

# bluefin-dx:stable
Tags: [
    "40",
    "20240715-40",
    "stable",
    "0cb40ac-40",
]

The generated tags for latest channel of this same image is this:

# bluefin-dx:latest
Tags: [
    "40",
    "20240715-40",
    "latest",
    "0cb40ac-40",
]

As you can see there is very major overlap

Latest and stable are on the same fedora version but are actually quite significantly different (see announcement of stable tag for bluefin)

I think it would be better if the tags were like this instead, with everything suffixed with -stable (aka the alt-tag chosen:

# removed the 40 tag
Tags: [
    "20240715-stable",
    "stable",
    "0cb40ac-stable",
]

noahdotpy avatar Jul 15 '24 11:07 noahdotpy

I was initially shocked because I thought we'd specced out every overlap. But now I'm just thinking: if latest and stable is the same version, why do you care about having separate tags?

I guess in my view the textual/numbered version tags are equivalent, with the textual ones being aliases to the numbered ones, but you are using them to mean something else?

xynydev avatar Jul 15 '24 16:07 xynydev

So in bluefin/aurora the stable tag is pretty much latest but with a gated kernel (from CoreOS stable), and it builds weekly.

The stable tag is the same fedora version as latest, but is actually different with some stuff.

I will probably end up just disabling the latest tag building anyway.

Maybe we should, instead of -40 have -stable?

noahdotpy avatar Jul 15 '24 21:07 noahdotpy

more info can be found on the bluefin 3.0 release announcement on discourse

noahdotpy avatar Jul 15 '24 21:07 noahdotpy

Yeah I didn't really take into account using the same version number on the same image. Yeah I'm thinking that the proposed set of tags is the best way to handle this kind of thing. Then we can go back to having the timestamp tag but with -alt-tag tacked onto it.

gmpinder avatar Jul 15 '24 21:07 gmpinder

We would still want to fully replace latest in the list of tags

gmpinder avatar Jul 15 '24 21:07 gmpinder

This will need to wait until https://github.com/blue-build/cli/pull/197 is merged in.

gmpinder avatar Jul 15 '24 21:07 gmpinder

@qoijjj as a heads up for future tag changes.

gmpinder avatar Jul 15 '24 21:07 gmpinder

How would it handle multiple alt-tags, would it do a tag with every alt-tag listed?

noahdotpy avatar Jul 25 '24 07:07 noahdotpy

I think it would just create xxx-alt-tag-one and xxx-alt-tag-two separately. If you want a tag with multiple alt-tags listed, you don't want multiple alt-tags.

xynydev avatar Jul 25 '24 09:07 xynydev