Ben Pfaff

`ddlog -o` option has weird behavior

2

`ddlog --help` says the following about `-o`: ``` -o DIR --output-dir=DIR Output directory (default based on program name). ``` To me, this means that the output directory is based on...

device_id discovery

2

It's not clear to me whether there's a way for a P4Runtime client to discover the `device_id` (or IDs) supported by the P4Runtime server that it is talking to. I...

use Preamble for MatchField?

1

The `MatchField` message contains everything in `Preamble` except for `alias`. It's not clear to me why `MatchField` doesn't just use Preamble. Perhaps it is because the `id` is scoped differently,...

semantics of negative bitwidths

2

Multiple places in the P4Runtime specification use 32-bit signed integer fields for bit widths. Is this a mistake? Are there intended semantics for negative bit widths?

Trait dbsp::trace::cursor::Cursor requires the client to use `key_valid()`, `step_key()`, `val_valid()`, `step_val()`, and so on. The Rust iterator interface is not supported. It works, but it isn't very Rusty and perhaps...

Trait `dbsp::trace::cursor::Cursor`'s `weight()` requires `&mut self`, but this does not make sense conceptually. See PR #286.

Also apply Lalith's suggested changes to concepts.md, and refill paragraphs there. Suggested by Lalith. Is this a user-visible change (yes/no): no

SQL checking waits for everything queued to compile to binary

2

When there are one or more programs compiling, the SQL compiler isn't invoked to check syntax until everything in the queue has finished compiling, so the user receives no feedback...

These metrics only appear when storage is enabled. Is this a user-visible change (yes/no): no

The top of the profile for storage benchmarks is always merging batches. Currently, merging occurs in the same thread as the rest of the work for a worker. We should...