s4cmd icon indicating copy to clipboard operation
s4cmd copied to clipboard

fixing license info in packaging

Open z-kovacs opened this issue 4 years ago • 6 comments

Pls review and merge if possible.

z-kovacs avatar Jan 18 '21 10:01 z-kovacs

@debodirno @rozuur @navinpai - could you pls advise why the test is failing when I just modified some licensing setup for packaging? Having a quick glance on the test script it does not seem to build a package, so I don't know how could I break an assumably correctly running test in master. Pls advise. Thanks!

z-kovacs avatar Jan 19 '21 08:01 z-kovacs

@debodirno @rozuur @navinpai - could you pls advise why the test is failing when I just modified some licensing setup for packaging? Having a quick glance on the test script it does not seem to build a package, so I don't know how could I break an assumably correctly running test in master. Pls advise. Thanks!

Try pushing your code to a branch in this remote. Travis CI has an issue with forks. Will soon move from Travis CI to Github Actions. Read for more information : https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

debodirno avatar Jan 21 '21 20:01 debodirno

@debodirno @rozuur @navinpai - could you pls advise why the test is failing when I just modified some licensing setup for packaging? Having a quick glance on the test script it does not seem to build a package, so I don't know how could I break an assumably correctly running test in master. Pls advise. Thanks!

Try pushing your code to a branch in this remote. Travis CI has an issue with forks. Will soon move from Travis CI to Github Actions. Read for more information : https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

I have no permission to push a branch into this repo. If you grant me perm I am happy to do it.

z-kovacs avatar Jan 21 '21 21:01 z-kovacs

@debodirno Let's migrate from Travis to Github actions, as a part of that effort this commit can be merged.

@z-kovacs Care to work on this migration?

rozuur avatar Jan 22 '21 06:01 rozuur

@debodirno Let's migrate from Travis to Github actions, as a part of that effort this commit can be merged.

@z-kovacs Care to work on this migration?

I can take a stab...first run seems to show same errors as travis

z-kovacs avatar Jan 23 '21 12:01 z-kovacs

@debodirno Let's migrate from Travis to Github actions, as a part of that effort this commit can be merged. @z-kovacs Care to work on this migration?

I can take a stab...first run seems to show same errors as travis

The error I see:

  (D)s4cmd.py:128  >> del_handler(<__main__.CommandHandler object at 0x7f2d0b4f68d0>, ['del', 's3://bucket/path/0/3.6.12/'])
  (D)s4cmd.py:128  >> validate(<__main__.CommandHandler object at 0x7f2d0b4f68d0>, 'cmd|s3', ['del', 's3://bucket/path/0/3.6.12/'])
  (D)s4cmd.py:130  << validate(<__main__.CommandHandler object at 0x7f2d0b4f68d0>, 'cmd|s3', ['del', 's3://bucket/path/0/3.6.12/']): None
  (D)s4cmd.py:128  >> del_files(<__main__.S3Handler object at 0x7f2d10709f28>, 's3://bucket/path/0/3.6.12/')
  (D)s4cmd.py:128  >> s3walk(<__main__.S3Handler object at 0x7f2d10709f28>, 's3://bucket/path/0/3.6.12/')
  (D)s4cmd.py:128  >> s3walk(<ThreadUtil(Thread-1, started daemon 139831427458816)>, <__main__.S3URL object at 0x7f2d0a93eef0>, 'path/0/3.6.12', 'path/0/3.6.12', [])
  (D)s4cmd.py:401  >> S3APICALL get_paginator('list_objects')
  (D)s4cmd.py:403  << S3APICALL get_paginator('list_objects'): <botocore.client.S3.Paginator.ListObjects object at 0x7f2d086b3e80>
  (E)s4cmd.py:182  [Exception] Unable to locate credentials
  (E)s4cmd.py:182  [Thread Failure] Unable to locate credentials

z-kovacs avatar Jan 23 '21 17:01 z-kovacs