homebridge-iRobot icon indicating copy to clipboard operation
homebridge-iRobot copied to clipboard

Add i3/i4 models to multiroom support to resolve #118

Open claytonmark opened this issue 2 years ago • 4 comments

i3/i4 models now have smart mapping: https://homesupport.irobot.com/s/article/64103

Tested on my i3 and it performs as expected.

claytonmark avatar May 09 '22 20:05 claytonmark

Is it possible to officially merge this to enable multi-room support for i3? The code change seems fine to me.

kejmUP avatar Nov 07 '22 12:11 kejmUP

Isn't the imprint mapping only added to the i3 and up? The changes seems to not take in to account the i2 and i1.

Madmatt06 avatar Nov 27 '22 03:11 Madmatt06

Isn't the imprint mapping only added to the i3 and up? The changes seems to not take in to account the i2 and i1.

This is correct. The i1/i2 models were launched after I made this change. I have updated the check to include only i3 and up models.

claytonmark avatar Dec 02 '22 21:12 claytonmark

@senorshaun are there any plans to merge this PR into the stable or beta versions any time soon? It resolves an issue I'm having with an i3 so I'm keen to see if this fixes multi-room for me.

sysophost avatar Aug 29 '23 05:08 sysophost