pystack icon indicating copy to clipboard operation
pystack copied to clipboard

Add gzip support

Open ecalifornica opened this issue 1 year ago • 2 comments

*Issue number of the reported bug or feature request: #168 *

Describe your changes Add check for core dump file ending in .gz. If so, decompress to temporary file and run analyzer on temporary file.

Testing performed Added a unit test following the pattern of current tests. It mocks calls to gzip and tempfile, asserts that the analyzer was called with the correct path. It does not test for any failure modes, and really only tests the mocks. Happy to add more tests if requested.

Additional context

ecalifornica avatar May 07 '24 21:05 ecalifornica

Thanks a lot for the PR! I will try to review it this week :)

pablogsal avatar May 07 '24 22:05 pablogsal

Great job! We are almost there

You need a news entry - an .rst file in the news folder (the other error in the Lint step you can ignore as we are fixing this in other PR).

pablogsal avatar May 13 '24 22:05 pablogsal

Is this the correct format for the news entry?

ecalifornica avatar May 20 '24 18:05 ecalifornica

Thanks for running the checks yesterday @godlygeek. I've picked up your fix for the Alpine test failure and removed the code that was causing the Python3.7 failure. Hopefully those changes should cause this PR to go green.

ecalifornica avatar May 25 '24 14:05 ecalifornica

Sorry this took too long to merge @ecalifornica and congrats on the merge!

Thanks a lot for being so patient with this and for following our (slow) feedback!

pablogsal avatar Jun 04 '24 19:06 pablogsal