bloomberg
Allow spinning a Memray environment up in codespaces
Update our Dockerfile to the latest Debian stable, and add a devcontainer.json based on it, with our build and test dependencies installed.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.86%. Comparing base (
41248ed) to head (b134158). Report is 42 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #582 +/- ##
==========================================
+ Coverage 92.55% 92.86% +0.30%
==========================================
Files 91 92 +1
Lines 11304 11234 -70
Branches 1581 2055 +474
==========================================
- Hits 10462 10432 -30
+ Misses 837 802 -35
+ Partials 5 0 -5
| Flag | Coverage Δ | |
|---|---|---|
| cpp | 92.86% <ø> (+6.92%) |
:arrow_up: |
| python_and_cython | 92.86% <ø> (-2.86%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
First comment I would like to add, spinning up the codespace took ~7 minutes. This is likely due to all the dependencies required for this currently considered codespace. This makes me wonder if a slimmed down version of this codespace might make sense for folks attempting to follow the tutorial (and not necessarily needing all of the dependencies)
I want to be clear, my suggestion is not to modify this codespace, it probably makes sense to leave this one as is, just some food for thought if we want to potentially shrink the time to create a codespace for folks. Then again, 7 minutes is not too long, so maybe optimization is overkill.
Just food for thought 😄
Do we know where these 7 minute are being spent? The dependencies are not that many so I am a bit surprised
I timed it at 5 minutes. https://gist.github.com/godlygeek/cc5bfd9e64da8b4c5f24178e735745cc shows the log. 3.5 minutes of that is installing the DPKG dependencies, most of which seemed to be spent installing nodejs and its deps, 0.5 minutes is setting up our virtualenv and installing our build and test deps, and 1 minute is building Memray from source, give or take a bit of rounding.