chef-bach
chef-bach copied to clipboard
contributed smartsense-chef recipe
I would think we'll need a wrapper recipe here @dbist. I see a number of attributes in the Smartsense cookbook which should be aligned with what we use in Chef-BACH:
-
node[:smartsense-chef][:java_home]
should equalnode[:bcpc][:hadoop][:java]
-
node[:smartsense-chef][:cluster_name]
should equalnode.chef_environment
as is our convention.
As an aside, it looks like your Test Kitchen configs may have polluted your cookbook:
-
Java attributes and an errant
include_recipe
would be good to pull out into your.kitchen.yml
Also you'll want to pull your apt config into attributes from hardcoded in your recipe as some Chef-BACH clusters are run behind proxies or without Internet access.
For reference, a wrapper cookbook in Chef-BACH today is the kafka-bcpc
cookbook which has a recipe to wrap attributes; for Smart Sense I would think simply a recipe in bcpc-hadoop
would suffice. (Some theory behind wrapper cookbooks can be found web-searching around too.)
~~node[:smartsense-chef][:java_home]
should equal node[:bcpc][:hadoop][:java]
~~
~~node[:smartsense-chef][:cluster_name]
should equal node.chef_environment
as is our convention.~~
~~As an aside, it looks like your Test Kitchen configs may have polluted your cookbook:~~
~~Java attributes
and an errant include_recipe
would be good to pull out into your .kitchen.yml
~~
~~Also you'll want to pull your apt config into attributes from hardcoded
in your recipe as some Chef-BACH clusters are run behind proxies or without Internet access.~~
@cbaenziger also, not sure how to leverage wrapper recipe over .kitchen.yml entries, it did not take effect, please advise
I updated trunk, most likely need to generate new PR?
@cbaenziger any updates on this?