blpapi-http icon indicating copy to clipboard operation
blpapi-http copied to clipboard

Run examples in the continuous integration

Open yupinghu opened this issue 10 years ago • 4 comments

After we have mocks for request/response (and eventually for everything), we should hook up running the examples during CI, to detect when there are errors in the examples. (See #81, for example.)

yupinghu avatar Feb 18 '15 23:02 yupinghu

The mock layer is substituting the blpapi-wrapper and have no knowledge of implementation details of it, so it won't be able to catch the service name error in #81, at least for now. We have to think it more if we want to capture that.

ericlu88 avatar Feb 19 '15 17:02 ericlu88

How is a mock layer of blpapi-wrapper useful? Would it be possible to have a mock layer that is a replacement of blpapi-node instead? This would facilitate deterministic regression testing of the blpapi-wrapper.

thmiceli avatar Feb 19 '15 17:02 thmiceli

The idea is to push blpapi-wrapper down to blpapi-node project, so that blpapi-http project is purely http server related functionality, which is the focus of our testing.

ericlu88 avatar Feb 19 '15 18:02 ericlu88

Ah ok. I was thinking that we'd actually run much of the real blpapi-wrapper code and therefore the errors generated by the request name map checks would fire. I would probably advocate for this regardless of what lives where, i.e. have the mock be a replacement for blpapi-wrapper as you suggest but share as much of the code as possible and only fake the calls to the underlying API as much as possible.

yupinghu avatar Feb 19 '15 19:02 yupinghu