blazingmq icon indicating copy to clipboard operation
blazingmq copied to clipboard

Sanitized builds are not using the sanitized build modes

Open hallfox opened this issue 8 months ago • 0 comments

https://github.com/bloomberg/blazingmq/blob/60f306dc5fe80f735dc164ce173b04687cf50317/CMakePresets.json#L60

https://github.com/bloomberg/blazingmq/blob/60f306dc5fe80f735dc164ce173b04687cf50317/docker/sanitizers/clang-libcxx-sanitizer.cmake#L92

The build logic in build_sanitizers.sh are all configuring builds for BlazingMQ with the Debug build type, ~~but the toolchain file used for those sanitized builds define all the sanitizer configuration flags in new build types named after the equivalent mode used on github CI. This script needs to change to set the build mode to the appropriate one based on the input from github CI.~~

https://github.com/bloomberg/blazingmq/blob/60f306dc5fe80f735dc164ce173b04687cf50317/docker/sanitizers/clang-libcxx-sanitizer.cmake#L132

So we seem to be overriding the Debug build type, but I have some reason to believe we aren't getting some UBSAN checks in this build. I'll investigate further.

hallfox avatar Jul 03 '25 15:07 hallfox