HSPlayer icon indicating copy to clipboard operation
HSPlayer copied to clipboard

Published 20 hours ago • verified publisher icon blommegard

fixes memory leaks and allows for a bit more customization

Open hwaxxer opened this issue 11 years ago • 3 comments

Fixes memory leaks due to capturing self in NSNotificationCenter addObserver block. Also allows for more customization such as autorepeating and autoplay and not allowing the controls to be visible.

hwaxxer avatar Nov 13 '13 16:11 hwaxxer

Nice pull request! When introducing the observations dict, do you think it makes sense to add all the existing notifications there as well, for nice deallocation? Or would we just skip it and have conditional removal in dealloc as well?

blommegard avatar Nov 13 '13 19:11 blommegard

I actually wanted to do that but I didn't have the time. I can do it this weekend though. thanks for open sourcing this!

hwaxxer avatar Nov 13 '13 21:11 hwaxxer

Waiting for that to merge then.

blommegard avatar Nov 13 '13 21:11 blommegard