blokada icon indicating copy to clipboard operation
blokada copied to clipboard

Blokada does not change theme dynamically

Open soredake opened this issue 2 years ago • 7 comments

When android theme changes to dark blokada's theme is still staying light, even when "system theme" is selected in options.

soredake avatar Sep 08 '21 07:09 soredake

What device, os?

kar avatar Sep 24 '21 06:09 kar

Redmi Note 5 Pro, crdroid (android 11)

soredake avatar Sep 24 '21 06:09 soredake

Same here, stock android 11

qwerty287 avatar Sep 24 '21 10:09 qwerty287

Do you restart the app fully? You need to kill the app if VPN is established or Keep Alive is enabled.

kar avatar Sep 24 '21 12:09 kar

OK, if I kill the app it works. But that's not a very nice behavior. Usually, android apps automatically switch to dark ui if it is changed, without an app restart or even an app kill. Actually, Android handles this exactly like this if you do not change it manually and if you have the theme declarations in both directories values and values-night.

qwerty287 avatar Sep 24 '21 14:09 qwerty287

Yep but you are talking about only some recent Android versions and only some device models. Theme handling has been historically very inconsistent in Android. We have done it with a separate library in order to support a broader range of devices. We may revisit it and go back to Android native way once the more recent Android versions are more common.

kar avatar Oct 22 '21 11:10 kar

once the more recent Android versions are more common.

https://www.xda-developers.com/android-distribution-numbers-2021/

soredake avatar Nov 23 '21 08:11 soredake

Blokada 5/6 now dynamically changes theme, closing.

soredake avatar Feb 14 '23 12:02 soredake