blocktrail-sdk-php icon indicating copy to clipboard operation
blocktrail-sdk-php copied to clipboard

Make Wallet & WalletInterface::coinSelection API consistent

Open n0n0n0n0 opened this issue 7 years ago • 1 comments

In Wallet.php public function coinSelection($outputs, $lockUTXO = true, $allowZeroConf = false, $feeStrategy = self::FEE_STRATEGY_OPTIMAL, $forceFee = null) {

in WalletInterface public function coinSelection($outputs, $lockUTXO = true, $allowZeroConf = false, $forceFee = null);

looks like param missing?

n0n0n0n0 avatar Sep 15 '17 18:09 n0n0n0n0

You're right, seems we forgot a new param.. This can stay open :)

Indeed if you're typehinting WalletInterface as you should be this would be annoying!

afk11 avatar Sep 18 '17 09:09 afk11