blocktrail-sdk-nodejs icon indicating copy to clipboard operation
blocktrail-sdk-nodejs copied to clipboard

Published 20 hours ago • verified publisher icon blocktrail

Support for RSK

Open philipglazman opened this issue 6 years ago • 3 comments

Preliminary PR for Rootstock support in SDK.

Added support for Rootstock wallet creation, addresses, and transaction building/signing.

philipglazman avatar Nov 19 '18 10:11 philipglazman

we normally avoid committing changes to the build directory unless it's build time - since it's between tags there's no real need to update it

afk11 avatar Nov 27 '18 21:11 afk11

No need for a createNewWallet since it builds upon an existing wallet and uses separate code paths if the initialised wallet is using the rootstock network.

philipglazman avatar Nov 28 '18 11:11 philipglazman

sorry! https://github.com/blocktrail/blocktrail-sdk-nodejs/blob/2404e55d8b4b1d62ac2ea5c452f47d006f39c6ea/lib/wallet.js#L889 maybe just revert to the array shizzle for the rsk balance, forgot we use that format elsewhere

afk11 avatar Dec 07 '18 15:12 afk11