blockscout icon indicating copy to clipboard operation
blockscout copied to clipboard

Error display the internal transaction status

Open yxsec opened this issue 1 year ago • 2 comments

Description

Failed internal transactions will be displayed as successful.

Example https://eth.blockscout.com/tx/0x468dfc854bed2d71fd94e2f72842df42a42c527f111284c5f00d90ea72ef9f83?tab=internal

image The transaction was failed, so all internal transaction should be failed. But the blockscout recorded these as successful. image

Type of the installation

Docker-compose

Type of the JSON RPC archive node

https://eth.blockscout.com/

Type of the chain

No response

Link to the page

No response

Steps to reproduce

No response

Backend version

v6.7.2-beta

Frontend version

v1.32.1

Elixir & Erlang/OTP versions

https://eth.blockscout.com/

Operating system

No response

Additional information

No response

yxsec avatar Aug 01 '24 10:08 yxsec

@yxsec this bug has been fixed in https://github.com/blockscout/blockscout/pull/9212. However, it is applied to new instances of transactions. Transaction, which you mentioned, has been re-fetched - currently internal trasnactions are marked as failed. If you have more examples please let us know. At the same time, we'll try to find such instances by ourselves and refetch related blocks as well.

vbaranov avatar Aug 02 '24 13:08 vbaranov

@yxsec this bug has been fixed in #9212. However, it is applied to new instances of transactions. Transaction, which you mentioned, has been re-fetched - currently internal trasnactions are marked as failed. If you have more examples please let us know. At the same time, we'll try to find such instances by ourselves and refetch related blocks as well.

More Example: https://eth.blockscout.com/tx/0x235d55b89fc84075ea5fb886f9f14305310cd6b0042b2a27dff9ccb890b1ef79?tab=internal @vbaranov

yxsec avatar Aug 24 '24 09:08 yxsec

Incorrect statuses in internal transactions for older blocks were fixed in https://github.com/blockscout/blockscout/pull/10654

Qwerty5Uiop avatar Sep 30 '24 14:09 Qwerty5Uiop