web3-onboard icon indicating copy to clipboard operation
web3-onboard copied to clipboard

font-size overwriting

Open Pasha8914 opened this issue 1 year ago • 3 comments

Current Behavior

In web3-onboard there are variables for font size, but for variables are not used because fixed values are used for @media

Line 46 set variable for font-size, Line 86 overwrite to hardcode value

image

Expected Behavior

variables need to be used everywhere

Steps To Reproduce

  1. Open web3-onboard
  2. set display width more than 768px
  3. look at element-inspector

What package is effected by this issue?

@web3-onboard/core

Is this a build or a runtime issue?

N/A

Package Version

2.7.12

Node Version

20

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Relevant log output

No response

Anything else?

Because of this problem, I can't customize web3-onboard for my application. In my app 1rem = 10px; and the text in the modal window is too small, I tried to overwrite the data in the variables (custom styles guid) but found this bug

Sanity Check

  • [X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

Pasha8914 avatar Feb 01 '24 05:02 Pasha8914

I have the same problem🤷‍♂️

dan1kov avatar Feb 01 '24 05:02 dan1kov

Same problem on my project

0xVoushi avatar Feb 02 '24 17:02 0xVoushi

@Adamj1232 @aaronbarnardsound @leightkt

Pasha8914 avatar Feb 06 '24 03:02 Pasha8914