Error Connect to metamask

[peterpan0708]

Current Behavior

all popular websites using web3-onboard have this issue, eg. curve.fi, https://onboard.blocknative.com/

Expected Behavior

should connect to metamask correctly

Steps To Reproduce

It's not 100% reproduce, but if you keep trying for 5 more times, it will happen

1. open website, connect to metamask

2. click disconnect button
3. close the website label
4. open the website
5. connect to metamask

What package is effected by this issue?

@web3-onboard/injected

Is this a build or a runtime issue?

Runtime

Package Version

latest

Node Version

18.15.0

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Anything else?

No response

Sanity Check

• [X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

[Adamj1232]

@peterpan0708 I tried on both site 10x across multiple browsers and was unable to reproduce. Can you create a reproducible example or video?

[peterpan0708]

@peterpan0708 I tried on both site 10x across multiple browsers and was unable to reproduce. Can you create a reproducible example or video?

https://github.com/blocknative/web3-onboard/assets/36805830/abc81479-cedc-43cd-b8eb-2131c1becf99

[peterpan0708]

@peterpan0708 I tried on both site 10x across multiple browsers and was unable to reproduce. Can you create a reproducible example or video?

2_1688692669.mp4

I think it's a common issue, because all of our team members can reproduce

[peterpan0708]

@Adamj1232 more information: our code stuck at this line go deep into the source code requestAccounts() doesn't return

[tim-schultz]

I'm also experiencing this error:

[Adamj1232]

@schultztimothy I think this is a different error than what is reported in this issue. The error you are noted we are aware of and we are troubleshooting with the walletconnect and metamask teams. Are you a dev with curve.fi?

[tim-schultz]

@schultztimothy I think this is a different error than what is reported in this issue. The error you are noted we are aware of and we are troubleshooting with the walletconnect and metamask teams. Are you a dev with curve.fi?

Thanks for your quick response! I'm not with Curve, but am a dev on Gitcoin's passport application and we are experiencing the same issue. We recently updated to "@web3-onboard/walletconnect": "2.4.0", and are about to release the update.

I assume since you all are actively working on it we should be good to release and the issue should be patched soon? Thanks again!

[Adamj1232]

@schultztimothy we have pinpointed the issue. MetaMask when handling a connection through WalletConnect requires a URL to be passed. This previously was populated within the WalletConnect package as the web3OnboardInit.appMetaData.explorer property. I have an open PR to add a WC init prop to define this more clearly as well as enhanced validation and documentation around this. To resolve this issue in the short term please pass in the dapp URL into web3OnboardInit.appMetaData.explorer or you can wait until the noted PR is in alpha to test with the walletconnect init prop dappUrl

[peterpan0708]

@schultztimothy we have pinpointed the issue. MetaMask when handling a connection through WalletConnect requires a URL to be passed. This previously was populated within the WalletConnect package as the web3OnboardInit.appMetaData.explorer property. I have an open PR to add a WC init prop to define this more clearly as well as enhanced validation and documentation around this. To resolve this issue in the short term please pass in the dapp URL into web3OnboardInit.appMetaData.explorer or you can wait until the noted PR is in alpha to test with the walletconnect init prop dappUrl

Hi, do you reproduce the Connecting... issue? Is there any progress? Thanks for the reply. @Adamj1232

[tim-schultz]

@schultztimothy we have pinpointed the issue. MetaMask when handling a connection through WalletConnect requires a URL to be passed. This previously was populated within the WalletConnect package as the web3OnboardInit.appMetaData.explorer property. I have an open PR to add a WC init prop to define this more clearly as well as enhanced validation and documentation around this. To resolve this issue in the short term please pass in the dapp URL into web3OnboardInit.appMetaData.explorer or you can wait until the noted PR is in alpha to test with the walletconnect init prop dappUrl

This fix worked for us!

We are experiencing issues still with using gnosis safe's wallet. Not sure if you have had any other reports of this

[taylorjdawson]

@peterpan0708 Did the release which included this PR resolve your issue?

[peterpan0708]

@peterpan0708 Did the release which included this PR resolve your issue?

no, this PR is about walletconnect, not reslove this issue

[Adamj1232]

@peterpan0708 is this still an issue after updating your local version of MetaMask extension to the latest version?