web3-onboard icon indicating copy to clipboard operation
web3-onboard copied to clipboard
verified publisher icon blocknative

Add Enkrypt and MEW Wallet DApp browser as SDKs

Open gamalielhere opened this issue 3 years ago • 1 comments

Description

Adds Enkrypt and MEW Wallet DApp browser as SDKs Rename current mew package to mew connect

Checklist

  • [x] The version field in package.json is incremented following semantic versioning
  • [x] The box that allows repo maintainers to update this PR is checked
  • [x] I tested locally to make sure this feature/fix works
  • [x] I have run yarn check & yarn build to confirm there are not any associated errors
  • [ ] This PR passes the Circle CI checks

gamalielhere avatar Sep 22 '22 20:09 gamalielhere

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web3-onboard-docs ❌ Failed (Inspect) Nov 16, 2022 at 10:40PM (UTC)

vercel[bot] avatar Sep 22 '22 20:09 vercel[bot]

Hey @gamalielhere thanks for this, we'll try to get a look at this one soon 😄

lnbc1QWFyb24 avatar Sep 28 '22 01:09 lnbc1QWFyb24

Hi @gamalielhere! Do you mind if I clone down your fork and make some updates? Might be easier than going back and forth through comments 😃

Adamj1232 avatar Oct 18 '22 21:10 Adamj1232

@Adamj1232 go for it! let me know if you need anything from our end

gamalielhere avatar Oct 18 '22 23:10 gamalielhere

@gamalielhere I made changes on your forked branch but do not have permissions to push. Have the current changes been verified through testing on your side? There is already a MEW package, was there a specific reason that you created a new mew-wallet package?

Adamj1232 avatar Oct 19 '22 15:10 Adamj1232

@Adamj1232 yes. I tested it using the demo folder and importing the packages directly.

That access method will be deprecated at some point in the near future. Also, the new mew-wallet package uses a web3 injection access method via the MEW wallet app's DApp Browser.

gamalielhere avatar Oct 19 '22 21:10 gamalielhere

@gamalielhere Ah gotcha, so we can deprecate the MEW package with the release of the MEW-wallet package? Im wondering if rather than a new package we do a major version change for the package with the breaking change. Also, I have local changes made but can't push to your forked branch.

Adamj1232 avatar Oct 19 '22 22:10 Adamj1232

@gamalielhere friendly ping - any updates on allowing push access to your repo or the question above?

Adamj1232 avatar Oct 24 '22 16:10 Adamj1232

@Adamj1232 I might have to close and open a new PR to enable write access to my changes it seems. Regarding the package, yes it can be deprecated in favor of this PR.

gamalielhere avatar Oct 25 '22 16:10 gamalielhere

@gamalielhere thank you for the push access! I have pushed some changes but will need your help to clear the build errors produced when running yarn build. Also, please merge in the latest v2-web3-onboard-develop branch when you have a moment and confirm there are no errors. Let me know when those are cleared and I can start testing, cheers!

Adamj1232 avatar Oct 25 '22 17:10 Adamj1232

@Adamj1232 sync'd and fixed the yarn build errors.

gamalielhere avatar Oct 25 '22 21:10 gamalielhere

@gamalielhere thank you! Have you tested this using the internal project demo? Im not sure how to test the mew-wallet package as there doesnt seem to be a provider injected on the desktop browser so the error warning there doesnt really make sense. Does this need to be used within the MEW app? Is mew-wallet on available on mobile?

Adamj1232 avatar Oct 26 '22 16:10 Adamj1232