web3-onboard icon indicating copy to clipboard operation
web3-onboard copied to clipboard

feat: core injected wallet support

Open itsmnthn opened this issue 3 years ago • 4 comments

Description

Adding Core(Avalanche Core) wallet support in inject wallet

Checklist

  • [x] The version field in package.json is incremented following semantic versioning
  • [x] The box that allows repo maintainers to update this PR is checked
  • [x] I tested locally to make sure this feature/fix works
  • [ ] I have run yarn type-check & yarn build to confirm there are not any associated errors
  • [ ] This PR passes the Circle CI checks

itsmnthn avatar Jul 22 '22 10:07 itsmnthn

Thanks for this @itsmnthn. We will review this and get it merged.

mahmud-bn avatar Jul 22 '22 16:07 mahmud-bn

@itsmnthn does this PR work on your end? I am not able to get it to work from your fork

Adamj1232 avatar Jul 25 '22 19:07 Adamj1232

@itsmnthn does this PR work on your end? I am not able to get it to work from your fork

I've tried adding custom wallet when initializing onboard check this project https://github.com/itsmnthn/nuxt3-web3-onboard-mvp

itsmnthn avatar Jul 26 '22 15:07 itsmnthn

@itsmnthn we have reached out to AvaLabs to get the issues with the wallet provider resolved

Adamj1232 avatar Jul 27 '22 15:07 Adamj1232

Closing as Core wallet support has been merged with #1259 and is available with injected-wallet package version 2.2.2-alpha.1

Adamj1232 avatar Sep 09 '22 14:09 Adamj1232