goose icon indicating copy to clipboard operation
goose copied to clipboard

deps: upgrade agent-client-protocol to 0.9.0

Open codefromthecrypt opened this issue 1 week ago • 2 comments

Summary

Updates the ACP to latest and fixes syntax

Type of Change

  • [ ] Feature
  • [ ] Bug fix
  • [ ] Refactor / Code quality
  • [ ] Performance improvement
  • [ ] Documentation
  • [ ] Tests
  • [ ] Security fix
  • [x] Build / Release
  • [ ] Other (specify below)

AI Assistance

  • [x] This PR was created or reviewed with AI assistance

Testing

Ran in Zed Screenshot 2025-12-14 at 9 14 13 AM

$ cat ~/Library/Logs/Zed/Zed.log                                                                                                                                        
--snip--
2025-12-14T09:10:11+08:00 WARN  [agent_servers::acp] agent stderr: Goose ACP agent started. Listening on stdio...
2025-12-14T09:10:15+08:00 WARN  [agent_servers::acp] agent stderr: Goose ACP agent started. Listening on stdio...
$  cut -c-120  ~/.local/state/goose/logs/cli/2025-12-14/20251214_091015.log                                                                                                  
{"timestamp":"2025-12-14T01:10:15.955487Z","level":"INFO","fields":{"message":"CLI command executed","counter.goose.cli_
{"timestamp":"2025-12-14T01:10:15.955534Z","level":"INFO","fields":{"message":"Starting Goose ACP agent server on stdio"
{"timestamp":"2025-12-14T01:10:16.225511Z","level":"INFO","fields":{"message":"Loaded extension: Extension Manager"},"ta
{"timestamp":"2025-12-14T01:10:16.225530Z","level":"INFO","fields":{"message":"Loaded extension: skills"},"target":"goos
{"timestamp":"2025-12-14T01:10:16.231151Z","level":"INFO","fields":{"message":"Loaded extension: developer"},"target":"g
{"timestamp":"2025-12-14T01:10:17.425654Z","level":"INFO","fields":{"message":"Loaded extension: GitHub"},"target":"goos
{"timestamp":"2025-12-14T01:10:17.508246Z","level":"INFO","fields":{"message":"Loaded extension: kiwi"},"target":"goose_
{"timestamp":"2025-12-14T01:10:17.508534Z","level":"INFO","fields":{"message":"ACP: Received initialize request Initiali
{"timestamp":"2025-12-14T01:10:17.510750Z","level":"INFO","fields":{"message":"ACP: Received new session request NewSess
{"timestamp":"2025-12-14T01:10:17.512444Z","level":"INFO","fields":{"message":"Created new ACP/goose session 20251214_10
{"timestamp":"2025-12-14T01:10:19.613676Z","level":"DEBUG","fields":{"message":"Compaction check: 8 / 272000 tokens (0.0
{"timestamp":"2025-12-14T01:10:20.695135Z","level":"DEBUG","fields":{"message":"WAITING_LLM_STREAM_START"},"target":"goo
{"timestamp":"2025-12-14T01:10:20.695843Z","level":"DEBUG","fields":{"message":"LLM_REQUEST: {\"messages\":[{\"content\"
{"timestamp":"2025-12-14T01:10:20.696739Z","level":"DEBUG","fields":{"message":"LLM_REQUEST: {\"messages\":[{\"content\"
{"timestamp":"2025-12-14T01:10:26.942701Z","level":"DEBUG","fields":{"message":"WAITING_LLM_STREAM_END"},"target":"goose

Related Issues

Prep before doing more ACP work

codefromthecrypt avatar Dec 14 '25 01:12 codefromthecrypt

@alexhancock I tried to match exactly what was before so that the diff is just about API updates. Lemme know if we need anything else on this.

codefromthecrypt avatar Dec 14 '25 01:12 codefromthecrypt

@alexhancock fyi I'm gonna drop all your historical comments per instructions so we can move forward.

codefromthecrypt avatar Dec 16 '25 01:12 codefromthecrypt

@angiejones any idea how we can get a fast track process for dependency upgrades like this? I want to help with ACP but compared to most projects and despite a contributor, I have zero access, so I have to do a lot of nagging. It puts at risk of drift before merge then restart again.

codefromthecrypt avatar Dec 16 '25 23:12 codefromthecrypt

can you not merge this yourself, or how can we make the process better here?

DOsinga avatar Dec 16 '25 23:12 DOsinga

@DOsinga sorry part of my comment wasn't clear enough. I am labeled as a maintainer, but I don't think that actually means maintainer. I have no ability to merge this PR, no merge button. So far, I think that just "maintainer" means I can post to discord.

Screenshot 2025-12-17 at 8 32 48 AM

On process...

Some...

  • use bots like renovate/dependabot etc so that no one has to chase up old version (at the cost of a lot of static)
  • only require a single approval to merge a dependency update
  • encourage maintainers to keep the queue clear and get rid of stuff like this
  • have an automated merge q, which might have boundaries like approved in the past
  • allowance to do follow-ups later (this was not an issue here, just saying that's often done)
  • have the opposite issue.. a pile on to merge low risk change due to foundation stats increment (not the change here as aaif doesn't yet gamify stats)

Right now, I had to nag mic, then a couple other times. I have to meta track a dependency update with similar effort to an actual spec change. This is the part I think we can tune.

codefromthecrypt avatar Dec 17 '25 00:12 codefromthecrypt

ah, I think that was an oversight that we didn't actually make you maintainer, just recognized you as one. you should be now. agree on all the things you say - now that you have write access, let's make it so!

sorry about that!

DOsinga avatar Dec 17 '25 00:12 DOsinga

Thanks for sorting this out @DOsinga. Glad I can help approve now also, or merge other people's low risk change.

codefromthecrypt avatar Dec 17 '25 00:12 codefromthecrypt