goose icon indicating copy to clipboard operation
goose copied to clipboard

Add tool calling emulation for OpenAI compatible providers

Open kirill670 opened this issue 1 month ago • 5 comments

Summary

Added tool calling emulation for OpenAI compatible providers.

Type of Change

  • [ x ] Feature
  • [ x ] Bug fix
  • [ ] Refactor / Code quality
  • [ ] Performance improvement
  • [ ] Documentation
  • [ ] Tests
  • [ ] Security fix
  • [ ] Build / Release
  • [ ] Other (specify below)

AI Assistance

  • [ x ] This PR was created or reviewed with AI assistance

Testing

Unit tests

Related issues

None

Screenshots/Demos (for UX changes)

Before:
None yet After:
None yet

Submitting a Recipe?

Email:

kirill670 avatar Nov 10 '25 00:11 kirill670

thanks @kirill670 do you mind doing the DCO signing thing? https://github.com/block/goose/pull/5648/checks?check_run_id=54928685902

(also a quick cargo fmt and ./script/clippy-lint.sh)

michaelneale avatar Nov 10 '25 05:11 michaelneale

I wonder if we get it working on openai, then we make sure ollama really is just using openai compatibility (not sure how close it is, but worth thinking about so) - but ideally want it on both, but they should be getting closer together.

I am also curious how well people are finding this emulation working

michaelneale avatar Nov 10 '25 22:11 michaelneale

it is already pretty close indeed; our ollama provider doesn't have an API key and why should it, but some people run their own ollama version on a remote server with an API key and I've told them to just use the OpenAi compatible custom provider and that seems to work

DOsinga avatar Nov 10 '25 23:11 DOsinga

also seems to be running into some checks - can you do the DCO thing also?

DOsinga avatar Nov 20 '25 18:11 DOsinga

This pull request has been automatically marked as stale because it has not had recent activity for 23 days.

What happens next?

  • If no further activity occurs, this PR will be automatically closed in 7 days
  • To keep this PR active, simply add a comment, push new commits, or add the keep-open label
  • If you believe this PR was marked as stale in error, please comment and we'll review it

Thank you for your contribution! 🚀

github-actions[bot] avatar Dec 15 '25 00:12 github-actions[bot]

closing as a bit old, feel free to re-open.

michaelneale avatar Dec 16 '25 03:12 michaelneale