goose icon indicating copy to clipboard operation
goose copied to clipboard

fix compaction in tool loops

Open jamadeo opened this issue 1 month ago • 2 comments

jamadeo avatar Oct 27 '25 16:10 jamadeo

FYI, noticed one more issue:

Joke request.json

Since I changed manual compaction to actually send a message, we're now picking up that message (as the most recent user message) and moving it after the compaction.

Maybe another argument for just passing in a manual_compaction flag and skipping the whole last user search entirely; I think otherwise we always just want to find the most recent user message and might not need to special case the last one.

katzdave avatar Oct 29 '25 16:10 katzdave

should we close this one now? or do we need to copy the test?

DOsinga avatar Nov 06 '25 04:11 DOsinga

should we close this one now? or do we need to copy the test?

Yeah closing. Moved the test to https://github.com/block/goose/pull/5618

Still porting a little more functionality there

katzdave avatar Nov 06 '25 20:11 katzdave