goose icon indicating copy to clipboard operation
goose copied to clipboard

feat(ui): add RSVP screen-reader component

Open mekly opened this issue 7 months ago • 6 comments

Adds an RSVP dialog for speed readers and reading disabilities Implementation for issue #2557

mekly avatar May 16 '25 02:05 mekly

I have hit a few usability issues I want to fix, but this patch gets the idea across for feedback purposes.

mekly avatar May 16 '25 18:05 mekly

@zanesq a lot of UI changes - would the tests cover these areas?

michaelneale avatar May 20 '25 00:05 michaelneale

thanks @mekly running tests now

michaelneale avatar May 20 '25 00:05 michaelneale

The key command and RSVP functionality works for me. Couple of Qs

  1. The styling changed for the attach file and send message button. Styling changes won't be easy, we will need to pass it by our designer @nahiyankhan. Do you need it to be bigger and bolder?
  2. The bottom bar model area is aligned left now was that intentional?
  3. Our designer may want to look at the RSVP modal design also.
  4. Please remove any console logs when you are ready.
Screenshot 2025-05-19 at 5 27 14 PM Screenshot 2025-05-19 at 5 24 17 PM

zanesq avatar May 20 '25 00:05 zanesq

Hey @mekly

Would suggest separating design and functionality on this one. We're aiming to introduce wider accessibility changes via a single settings function that increases sizes, contrasts etc across the entire UI vs piecemeal.

Screenshot 2025-05-22 at 11 05 52 AM

This may be something to consider with these changes you've proposed above, would love to help out on that endeavour as it'll make the entire experience more approachable for those who'd require it.


Regarding the modal Im attaching some suggestions you may consider to bring the styling closer to current modals.

Screenshot 2025-05-22 at 11 02 47 AM

Would love to pair on this work to get it over the line

spencrmartin avatar May 22 '25 15:05 spencrmartin

"Would love to pair on this work to get it over the line" - How can I help? I honestly thought it might be a long shot to get this included, I appreciate the attention on it. Apologies for not seeing that there had been an update, it fell off my radar for a minute.

mekly avatar Jun 03 '25 16:06 mekly

Closing due to inactivity and the interface has changed a lot. Feel free to reopen if you want to merge in main and make it work again.

zanesq avatar Jul 24 '25 17:07 zanesq